Make ozone diagnostic compatible with CMIP7 data#704
Conversation
|
FYI @hb326 |
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
| # Make sure only grid cells south of 80N are considered as there are no | ||
| # measurements north of 80N in March. Specifying 85N as northern boundary | ||
| # in the orignal 'recipe_ref_ozone.yml' is a bug! | ||
| # in the orignal 'recipe_ref_ozone_cmip7.yml' is a bug! |
There was a problem hiding this comment.
Perhaps fix this now that you're updating the recipe anyway?
There was a problem hiding this comment.
Yes, @axel-lauer and/or @hb326 are on it
There was a problem hiding this comment.
I just corrected the latitudes in this branch: https://github.com/ESMValGroup/ESMValTool/tree/test_REF_recipe_ozone_with_CMIP7_data
@hb326 kindly agreed to test the changes. If the tests are successful, the modification of the recipe in ozone.py mentioned above can be removed.
There was a problem hiding this comment.
Great! Let me know when this is finished, will update the branch here afterwards.
There was a problem hiding this comment.
I ran the updated recipe (for CMIP6), and the changes from @axel-lauer did not break it. It ran just fine. So from my side this is good to be updated.
Description
Checklist
Please confirm that this pull request has done the following:
changelog/