Remove orphaned improved_* files from the pre-InsightFace era - #3
Open
ChuckBuilds wants to merge 1 commit into
Open
Remove orphaned improved_* files from the pre-InsightFace era#3ChuckBuilds wants to merge 1 commit into
ChuckBuilds wants to merge 1 commit into
Conversation
PR #1 (a Cursor background agent run) added a parallel dlib-based accuracy improvement as new files, but PR #2 replaced the whole detection/clustering stack with InsightFace before #1 was merged. Nothing in the app imports these files; they describe an approach the codebase no longer uses. Co-Authored-By: Claude Fable 5 <[email protected]>
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. 💤 Files selected but had no reviewable changes (7)
⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #1 (a Cursor background agent) added a standalone dlib-based accuracy improvement (
improved_face_detector.py,improved_face_clusterer.py,improved_worker.py,improved_config.py,improved_app_integration.py,test_improved_system.py,IMPROVED_FACIAL_RECOGNITION_GUIDE.md), but it landed just before PR #2, which replaced the entire detection/clustering stack with InsightFace. Nothing inapp.py,cli.py, orpipeline.pyimports any of these files — they're dead code describing an approach the repo no longer uses.Removing them so the tree only contains what's actually running.
Test plan
grepacross the repo confirms no other file references anyimproved_*module🤖 Generated with Claude Code