Refresh all refs in external source mirrors#277
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
An existing mirror was refreshed with
git fetch <url>, which bypassed the mirror remote's+refs/*:refs/*refspec. Commits added later on non-default branches remained unavailable, so locked external source SHAs failed withnot a tree object.Change
Refresh the configured
originremote so the mirror refspec fetches every ref. Add a regression test that creates the mirror, advances a non-default branch, returns the source HEAD to the default branch, and locks the new feature-branch commit.Verification
cargo test -p fkst-framework --test deps_cli(19 passed)FKST_RUNTIME_ROOT=/tmp/fkst-substrate-mirror-fetch-self-test ./target/debug/fkst-framework --self-test⟦AI:FKST⟧