fix(cli): allow --autoConnect in chrome-devtools start#1859
fix(cli): allow --autoConnect in chrome-devtools start#1859zerone0x wants to merge 1 commit intoChromeDevTools:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
@zerone0x Thanks for the PR for us to be able to merge you will need to sign the CLA. |
|
|
||
| // Not supported in CLI on purpose. | ||
| delete startCliOptions.autoConnect; | ||
| // autoConnect is supported by the CLI. |
There was a problem hiding this comment.
Nit: Let's remove this comment.
There was a problem hiding this comment.
@zerone0x The comment is still there on the latest commit.
There was a problem hiding this comment.
The comment was resolved but the change is not there, could you please remove the changes to this file?
zerone0x
force-pushed
the
fix/cli-auto-connect
branch
from
8316b51 to
64bb210
Compare
|
done: removed the nit comment and updated the commit author (zerone0x). force-pushed branch to update PR (64bb210). |
2 participants
Summary
Testing
Fixes #1184