fix: no need to expose postgres api endpoint#3
Open
benhaotang wants to merge 1 commit into
Open
Conversation
Since in the compose file, it is already using the same jetkvm network, there is no need to expose the postgres DB endpoint to 0.0.0.0. This will help to make the service more secure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks a lot for the original hard work, your doc is a lot cleaner than the original repo.
Today I received a warning from the german IT security agency(BSI) about a weak exposed postgres DB endpoint on my VPS, after digging, I find that it was actually due to this open port here, it is port forwarding 5432->0.0.0.0:5432, which make it venerable to attacks.
Since in the compose file, it is already using the same "jetkvm" network, which can be queried as api-db in any participant services, there is no need to expose the postgres DB endpoint to 0.0.0.0. This will help to make the service more secure.
Btw, I am hosting the 0.5.8 ui version and didn't run into any problem, so I would suggest also bumping the version number.