chore: bump CI Node versions to 22 and 24#524
Conversation
Node 18 is EOL; switch test matrix from [18, 20] to [22, 24] per @nflaig in ChainSafe#495. Bump benchmark workflow to Node 24 to match the release workflow. Closes ChainSafe#495 🤖 Generated with AI assistance
|
I believe this might need some repo setting changes to be able to merge it cc @wemeetagain |
|
Triaged before you get a chance to look at it — the blocker here isn't a repo setting. I checked:
The actual blocker is two failing checks: Master's last Fix is probably a one-liner — pass the timeout as the 3rd arg to |
|
@lodekeeper please fix the tests as part of this PR |
`vi.setConfig({testTimeout: 30 * 1000})` was called inside the `it()`
callback, which does not affect the currently-running test's timeout.
On Node 22/24 runners the mainnet `BeaconState/ssz_random` cases take
16-17s and exceed the default 15s, causing `Tests Node (22)` and
`Tests Node (24)` to fail. Move the timeout to the third argument of
`it()` so it actually applies.
🤖 Generated with AI assistance
|
Pushed |
|
Heads up — the push landed |
[email protected] requires Node 22.13+, but the Bun job installed pnpm globally via Bun and ran it under the ubuntu-latest default Node 20: warn: This version of pnpm requires at least Node.js v22.13 warn: The current version of Node.js is v20.20.2 Error [ERR_UNKNOWN_BUILTIN_MODULE]: No such built-in module: node:sqlite Set up Node 22 explicitly before installing Bun, and use corepack to provide pnpm (mirrors the test-node job). Drops the duplicated oven-sh/setup-bun steps and bumps checkout to v3 for consistency. 🤖 Generated with AI assistance
Summary
[18, 20]to[22, 24](Node 18 is EOL).20to24to match the release workflow.Closes #495
Test plan
test-nodematrix for both Node 22 and Node 24🤖 Generated with AI assistance