Fix timezone handling causing newly created events to disappear (#108)#212
Open
sakshibhatia17 wants to merge 1 commit into
Open
Fix timezone handling causing newly created events to disappear (#108)#212sakshibhatia17 wants to merge 1 commit into
sakshibhatia17 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes Issue #108.
Root Cause
The frontend extracted dates using
toISOString().split('T')[0], which converts local time to UTC before extracting the date. For users in timezones ahead of UTC (e.g. IST), newly created events could be assigned to the previous calendar day, causing them to be filtered out from "My Events".Additionally, the mock database could throw an error when iterating over events without attendees.
Changes
toISOString().split('T')[0]withdayjs().format('YYYY-MM-DD')to preserve the user's local calendar date.event.attendeesin the mock database.Verification
Fixes #108