Skip to content

Remove Xpdfutils in favor of Poppler Utils#170

Merged
yaronkoren merged 5 commits into
masterfrom
jeffw16/remove-xpdfutils
Jun 8, 2026
Merged

Remove Xpdfutils in favor of Poppler Utils#170
yaronkoren merged 5 commits into
masterfrom
jeffw16/remove-xpdfutils

Conversation

@jeffw16

@jeffw16 jeffw16 commented Jun 8, 2026

Copy link
Copy Markdown
Member

No description provided.

jeffw16 added 3 commits June 8, 2026 11:26
Changed position of poppler-utils to be next to media processing packages, and removed the redundant xpdf-utils from the Dockerfile.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the CanastaBase container image to drop xpdf-utils and rely on poppler-utils for PDF-related utilities, and bumps the project version accordingly.

Changes:

  • Bumped CanastaBase version from 1.3.8 to 1.3.9.
  • Updated Dockerfile to remove xpdf-utils and ensure poppler-utils is installed (deduplicating it in the package list).
  • Added a 1.3.9 entry to RELEASE_NOTES.md documenting the change.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
VERSION Version bump to 1.3.9.
RELEASE_NOTES.md Adds release note for 1.3.9 describing the switch from Xpdfutils to Poppler utils.
Dockerfile Removes xpdf-utils and installs poppler-utils (single occurrence) for PDF tooling in the image.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@yaronkoren

Copy link
Copy Markdown
Member

The commit description doesn't seem to match the actual code - both Xpdfutils and Poppler Utils are being removed.

@yaronkoren

Copy link
Copy Markdown
Member

Also, please keep changes separate from version releases - could you please remove the version release part of this patch?

@jeffw16

jeffw16 commented Jun 8, 2026

Copy link
Copy Markdown
Member Author

@yaronkoren:

  1. Poppler Utils has not been removed. It has been moved to line 38 so it is next to the packages for media processing (e.g. ImageMagick).
  2. Where will the version be updated if not in this patch?

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

🐳 The image based on b108f9a0 commit has been built with 1.43.8-20260608-170 tag as ghcr.io/canastawiki/canasta-base:1.43.8-20260608-170

@yaronkoren

Copy link
Copy Markdown
Member

Oh, I missed the line where Poppler Utils gets (re-)added. I still think the commit message is a little misleading, but it's not as big a deal.

@jeffw16

jeffw16 commented Jun 8, 2026

Copy link
Copy Markdown
Member Author
  1. The version bump has now been removed from this PR
  2. Sorry to hear about the potentially confusing commit message — nonetheless, it will be rendered irrelevant because this PR will be squashed upon merge into the master branch.

@yaronkoren

Copy link
Copy Markdown
Member

No, I meant that "Remove Xpdfutils in favor of Poppler Utils" is misleading because it makes it sound like Poppler Utils wasn't there before. But it's fine, probably.

@cicalese cicalese left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaronkoren yaronkoren merged commit c814025 into master Jun 8, 2026
3 checks passed
@jeffw16 jeffw16 deleted the jeffw16/remove-xpdfutils branch June 8, 2026 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants