feat(metrics): add prometheus latency histogram for /api/subscriptions #873 - #1027
Merged
greatest0fallt1me merged 3 commits intoJul 29, 2026
Merged
Conversation
- Add subscriptions_request_duration_seconds histogram with buckets tuned for subscription operations (0.001s to 10s) - Add recordSubscriptionsLatency and resetSubscriptionsMetrics functions - Add timing middleware to subscription routes - Add focused tests for histogram registration, direct recording, and route integration covering all HTTP results (success, 4xx, 5xx) Closes CalloraOrg#873
|
@TINEROW Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
CI passed, solid PR — merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds a Prometheus
subscriptions_request_duration_secondshistogram for/api/subscriptionswith explicit buckets and route label, enabling latency observability for all subscription endpoints.Related Issue
Closes #873
Changes
subscriptions_request_duration_secondshistogram insrc/metrics/registry.tswith explicit buckets (0.001s–10s) and recording functionrecordSubscriptionsLatency(method, statusCode, durationMs)src/routes/subscriptionRoutes.ts— addedrecordTimingMiddlewarethat captures full request lifecycle (success 2xx, error 4xx, 5xx) with method and status_code labelssrc/__tests__/subscriptionsLatency.test.ts— 14 tests covering: histogram registration, direct recording (method/status_code labels, duration conversion, accumulation), route integration (success, 404, validation errors), and metric resetVerification Results
subscriptions_request_duration_secondswith route, method, status_code labelsTimeline