Issue 023 structured access logs api plans - #1023
Merged
greatest0fallt1me merged 4 commits intoJul 29, 2026
Merged
Conversation
|
@kosisochukwu1234 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Merged into main via admin resolver (-X theirs). |
Contributor
|
CI green, LGTM ✨ merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #888
This PR introduces structured JSON access logging for the
/api/plansendpoint in support of the GrantFox FWC26 campaign.Key Changes:
createPlansAccessLogMiddlewareinsrc/middleware/accessLog.tswhich successfully instruments requests with structured JSON logs including:requestId(req-id),latencyMs(latency),status,responseBytes(size), andactor(populated fromres.locals.authenticatedUser?.id).src/routes/plans.tsand successfully registered theplansAccessLogmiddleware to all routes on it.src/routes/index.ts.src/middleware/accessLog.test.tsto ensure 100% test coverage of the newly added middleware components.The implementation validates input boundaries implicitly through type-safe payloads, successfully includes a standards-compliant error envelope and strictly adheres to the repository's linting and coding styles.