fix: resolve invoices health check bug (closes #049) - #1014
Merged
greatest0fallt1me merged 3 commits intoJul 29, 2026
Conversation
|
@IFEANYIBRIGHT Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Green across the board — merging. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #914
Summary
Fixes src/routes/invoices/health.ts — the dependency probe for /api/invoices's external dependencies was returning incorrect/broken status output. 3 failing tests → all 14 passing after the fix.
Changes
Fixed the health check logic in src/routes/invoices/health.ts so it correctly probes and reports the status of each external dependency for the invoices route.
No new endpoints added — existing /api/invoices/health behavior corrected to match spec.
Testing
Existing test suite in health.test.ts now passes in full (14/14).
Ran sibling suites (routes/invoices, routes/health, routes/admin/health) — 64 tests passing.
Did not run lint/typecheck in this environment (tooling issue on my end, unrelated to the change) — please run npm run lint / tsc on your side before merge.
Notes
Scope was limited to the one file per the issue's suggested execution; did not touch other files.