test: add end-to-end integration tests for /api/billing (#949) - #1010
Merged
greatest0fallt1me merged 3 commits intoJul 29, 2026
Merged
Conversation
Implements Supertest integration tests that hit the full /api/billing
router end-to-end, covering:
- POST /api/billing/deduct: happy path, DB persistence, response shape
- Row-level idempotency via requestId (alreadyProcessed flag)
- Idempotency-Key header replay (Idempotent-Replayed header verified)
- Idempotency-Key conflict with different body → 409 IDEMPOTENCY_CONFLICT
- Input validation: missing requestId, empty apiId, all invalid amountUsdc
formats (zero, negative, non-numeric, too many decimals, empty string)
- Auth enforcement: absent header, wrong-secret JWT, expired JWT → 401
- Malformed JSON body → 400
- x-correlation-id propagation verified via response tracing header
- GET /api/billing/deduct/request/:id: found, 404, unauthenticated
- POST /api/billing/disputes: open dispute, unauthenticated → 401
- GET /api/billing/disputes: list, unauthenticated → 401
- Concurrent identical requestId race → exactly one DB row
Infrastructure:
- pg-mem in-process DB (no Docker required)
- Soroban RPC fully mocked (no real network calls)
- JWT signed with JWT_SECRET from jest.env-setup.cjs
- Each test provisions its own isolated DB and tears it down in finally{}
Closes CalloraOrg#949
|
@Fayedamz Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
LGTM — clean, tested. Merged 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements Supertest integration tests that hit the full /api/billing router end-to-end, covering:
Infrastructure:
Closes #949