Feat: Cache "Open" Project#254
Open
karyao wants to merge 8 commits into
Open
Conversation
fix error message
karyao
force-pushed
the
feat_219_cache_open_applications
branch
from
95ccd78 to
7db32fb
Compare
jbriones1
requested changes
Jun 7, 2026
jbriones1
left a comment
jbriones1
left a comment
Collaborator
There was a problem hiding this comment.
I think the tooltip behaviour you've added could go into a tooltip module in the csss-code library. Maybe as a directive that components can add so they can easily add tooltips to themselves.
|
|
||
| router = inject(Router); | ||
|
|
||
| private platformId = inject(PLATFORM_ID); |
Collaborator
There was a problem hiding this comment.
Not sure why we need the PLATFORM_ID. Our application should only be accessed through a browser and unit tests should automatically inject the PLATFORM_ID to be browser.
Collaborator
There was a problem hiding this comment.
Did the tests require the PLATFORM_ID be injected? I thought they would automatically inject browser.
| @media (min-width: g.$breakpoint-large) { | ||
| :host { | ||
| grid-template-columns: min-content auto; | ||
| grid-template-columns: min-content 1fr; |
Collaborator
There was a problem hiding this comment.
Was there an issue with using auto? Iirc, this would fill any empty space, which I can't remember if I wanted or not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #219
Description:
Caching what tabs are opened for the user, so it will show up if the page is refreshed or the site is visited.