feat: more useful default page#30
Merged
Merged
Conversation
feat: 240 sample option for science readings feat: eef distance display
There was a problem hiding this comment.
Pull request overview
Updates the default UI experience by expanding telemetry graph sample window options, adjusting the default mosaic dashboard layout to surface more useful panels, and adding end-effector distance readout to the arm control panel.
Changes:
- Added a 240-sample option to the telemetry graph window-size selector.
- Updated the default
MosaicDashboardlayout to prioritize waypoint list, PDB rails, ESP sensor, and arm control panels. - Subscribed to
/eef_distanceinArmControlPaneland displayed a derived distance value in the UI.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/components/TelemetryGraph.tsx | Adds a 240-sample window option to improve longer-range telemetry viewing. |
| src/components/panels/MosaicDashboard.tsx | Changes the default tile layout to show different panels by default. |
| src/components/panels/ArmControlPanel.tsx | Adds ROS subscription and UI display for end-effector distance. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+50
to
+53
| const handleDistance = (msg: any) => { | ||
| setDistance(msg.distance); | ||
| setDistanceStatus(msg.status); | ||
| }; |
Comment on lines
+65
to
+70
| const distance_with_offset = distance - GRIPPER_OFFSET; | ||
|
|
||
| if (distanceStatus === 1) return `Error (${distance_with_offset.toFixed(3)})`; | ||
| if (distanceStatus === 2) return `Invalid (${distance_with_offset.toFixed(3)})`; | ||
|
|
||
| return distance_with_offset.toFixed(3); |
Comment on lines
+62
to
+69
| const getDistanceDisplay = () => { | ||
| const GRIPPER_OFFSET = 0.18; | ||
| if (distance === null) return 'No data'; | ||
| const distance_with_offset = distance - GRIPPER_OFFSET; | ||
|
|
||
| if (distanceStatus === 1) return `Error (${distance_with_offset.toFixed(3)})`; | ||
| if (distanceStatus === 2) return `Invalid (${distance_with_offset.toFixed(3)})`; | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: 240 sample option for science readings
feat: eef distance display