feat: allow folder-specific filters#9
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
list_files, query, filter_values did not support folder-specific filters until now. However, some datasets may have metadata in folders which is not present in the file name. This is the case for the L4-KaRIn dataset which has the version number in the folder name, but not in the file name.
This PR allows the intermediate nodes declared in the layouts - these intermediate nodes represent folders - to be used as filters in the
list_files,map,queryandfilter_valuesmethods. Instead of using the file name convention fields, we aggregate all fields from all declared conventions in the layouts.Until now, layouts were assumed to share the file name convention. This means that all filtering fields could be applied to all layouts. This assumption is not true anymore. We need to introduce new behaviors when the given filters are specific to the intermediate nodes, but these nodes do not exist. The following cases were implemented: