Stabilise vibrational regression calculations#333
Draft
harryswift01 wants to merge 10 commits intomainfrom
Draft
Stabilise vibrational regression calculations#333harryswift01 wants to merge 10 commits intomainfrom
harryswift01 wants to merge 10 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves numerical stability and determinism in the vibrational entropy regression path.
The changes focus on using the appropriate symmetric eigensolver for covariance matrices and ensuring group traversal/indexing is deterministic. This targets intermittent CI-only regression failures where vibrational entropy components differed between otherwise equivalent runs.
Changes
Stabilise covariance eigendecomposition
Enforce deterministic group handling
Impact