Add wildfire emissions for ICON 2D-Aerosol based on GFAS data

[drieg]

Description

Add wildfire emission climatology which is needed for ICON's 2D-Aerosol implementation. The climatology is based on seasonal averages over 10 years of GFAS emission data from CAMS.

See also the correponding data merge request.

Workflow for merging PRs

Please read these instructions carefully and follow the steps below before requesting a review by the maintainers. This way we can ensure a smoother review process and your changes will be merged sooner.

Additionally, if this is the first PR you open in EXTPAR make sure to read the "Information for EXTPAR Developers" section in the documentation.

Checklist

• Provide a detailed description of your changes in the "Description" section above.
• If you implemented a new feature:
  • Document it in the correct Markdown file(s) under the docs/ directory.
  • Add a new test or make sure your changes are already tested.
• Your code follows the style guidelines.
• Your changes only touch the files/lines relevant for you.
• All four required checks pass (see "Testing and debugging" for more details).
• No conflicts with the base branch.

If all the points above are satisfied you can ask for a review by selecting stelliom as a reviewer.

For any questions please ping @stelliom on this PR.

Testing and debugging

The most important test for PRs is the one labeled "EXTPAR Testsuite on Jenkins". This checks that the results of all testcases (described by the namelists in test/testsuite/data) did not change compared to the references.

You can launch the testsuite by writing launch jenkins as a comment in the PR that you want to test. Once completed, the result of the testsuite will be shown on the PR (failure or success).

If you need more details on the testsuite results (e.g., if you are trying to debug an error or you are simply unsure why the tests fail) you can launch the testsuite with launch jenkins(debug). This will run the tests as usual, but, once completed, you will be given a URL (via a comment on the PR) to access the logfiles and namelists of all tests that were run.

[drieg]

launch jenkins(debug)

[jenkins-apn]

The testsuite you launched for this PR has failed. You can inspect the results at this link.

[drieg]

launch jenkins(debug)

[jenkins-apn]

The testsuite you launched for this PR has failed. You can inspect the results at this link.

[drieg]

launch jenkins(debug)

[jenkins-apn]

The testsuite you launched for this PR has failed. You can inspect the results at this link.

[drieg]

launch jenkins(debug)

[stelliom]

Note that Jenkins might not work from 16:00 to 16:30, there's maintenance on the system.

[jenkins-apn]

The testsuite you launched for this PR has failed. You can inspect the results at this link.

[stelliom]

Well, that fixed the issue, but now you have other errors.

In addition to that, I am seeing that the existence_compiler.sh test is failing, which probably means you have some warnings during compilation. I think I have to check this myself though, unless you might already have an idea what may cause compiler warnings.

[drieg]

launch jenkins(debug)

[drieg]

launch jenkins(debug)

[drieg]

I hope this fixes the issues now. Is there any way to cancel a previous pipeline?

[jenkins-apn]

The testsuite you launched for this PR has failed. You can inspect the results at this link.

[drieg]

@stelliom While the mpim test is still pending (this should be fixed hopefully), the new icon_global test fails with

netCDF reference files found

which seems to be a bit misleading. The message should be netCDF reference filesnotfound, or do I miss something? I think that is the problem: I added a new test, activated the tolerance checker but there is of course no reference data available.

Can you add the reference data? Alternatively, I could simply deactivate the checker.

[jenkins-apn]

The testsuite you launched for this PR has failed. You can inspect the results at this link.

[stelliom]

The message should be netCDF reference files not found

Yes, you are right, there is a typo in the code. I will fix it in this PR directly if you don't mind.

Can you add the reference data?

Doing it now, might take an hour or two depending on the system.

[stelliom]

launch jenkins(debug)

[jenkins-apn]

The testsuite you launched for this PR has completed successfully. You can inspect the results at this link.