fix(parse): ignore undefined options so defaults are preserved#1241
Open
abhu85 wants to merge 1 commit into
Open
fix(parse): ignore undefined options so defaults are preserved#1241abhu85 wants to merge 1 commit into
abhu85 wants to merge 1 commit into
Conversation
`new ParserOptions({ delimiter: undefined })` threw `TypeError: Cannot
read properties of undefined (reading 'length')` because `Object.assign`
copied the explicit `undefined` over the default `,`. Optional options
are typed `?`, so passing `undefined` should fall back to the default.
Filter out `undefined` entries before assigning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Closes #1160.
ParserOptionsdeclares optional fields with defaults, then doesObject.assign(this, opts). BecauseObject.assigncopies enumerableundefinedvalues, explicitly passing an optional option asundefinedoverwrites its default. Fordelimiterthis then throws:The options type marks every field optional (
delimiter?: string), so passingundefinedshould be equivalent to omitting it — i.e. fall back to the default,— not blow up. This bites anyone forwarding options that themselves default toundefined.Fix
Filter out
undefinedentries before assigning, so defaults declared on the class are preserved:This is general (any explicitly-
undefinedoption now falls back to its default) and changes nothing for callers passing real values.Test plan
ParserOptionstest:{ delimiter: undefined }resolves to the default,.mainwith the reportedTypeError; passes with the fix.jest packages/parse— 373 passing, no regressions.eslint --max-warnings 0andprettier --checkclean on the changed files.