fix: update default agent-native source path#31
Conversation
|
Thanks for digging into this! I think the fix is pointing the wrong direction, though — it would break the check for the canonical checkout layout. I tested both defaults against a real sibling
The repo's authoritative doc, Rather than swapping one hardcoded base for another (which just moves the breakage to the other layout), could we try both bases so either checkout works without needing const defaultFrameworkPaths = [
path.resolve(repoRoot, "../agent-native/framework"),
path.resolve(repoRoot, "../agent-native"),
];…then fall through them in resolution (first that resolves wins). That keeps your setup working without regressing the documented one. |
Summary: Update the sync script's default Agent Native source path to match the current sibling checkout layout.\n\nWhy: The contributing docs clone BuilderIO/agent-native into ../agent-native, and the sync script already resolves that layout when the path is passed explicitly. Without AGENT_NATIVE_FRAMEWORK_PATH, however, npm run check defaulted to ../agent-native/framework, which does not exist in the current repo layout and caused the check to fail.\n\nWhat changed:\n- Changed the default source path from ../agent-native/framework to ../agent-native.\n\nHow to test:\n- npm run check\n- AGENT_NATIVE_FRAMEWORK_PATH=../agent-native npm run check\n- git diff --check\n\nNotes: No migrations or breaking changes.