Skip to content

fix: update default agent-native source path#31

Open
CooperSheroy wants to merge 1 commit into
BuilderIO:mainfrom
CooperSheroy:catalina/default-agent-native-path-20260628
Open

fix: update default agent-native source path#31
CooperSheroy wants to merge 1 commit into
BuilderIO:mainfrom
CooperSheroy:catalina/default-agent-native-path-20260628

Conversation

@CooperSheroy

Copy link
Copy Markdown

Summary: Update the sync script's default Agent Native source path to match the current sibling checkout layout.\n\nWhy: The contributing docs clone BuilderIO/agent-native into ../agent-native, and the sync script already resolves that layout when the path is passed explicitly. Without AGENT_NATIVE_FRAMEWORK_PATH, however, npm run check defaulted to ../agent-native/framework, which does not exist in the current repo layout and caused the check to fail.\n\nWhat changed:\n- Changed the default source path from ../agent-native/framework to ../agent-native.\n\nHow to test:\n- npm run check\n- AGENT_NATIVE_FRAMEWORK_PATH=../agent-native npm run check\n- git diff --check\n\nNotes: No migrations or breaking changes.

@steve8708

Copy link
Copy Markdown
Contributor

Thanks for digging into this! I think the fix is pointing the wrong direction, though — it would break the check for the canonical checkout layout.

I tested both defaults against a real sibling agent-native checkout (which has a framework/ subdir):

  • ../agent-native/framework (current): ✅ resolves — finds the skills under framework/.agents/plugins/agent-native-visual-plans/skills/...
  • ../agent-native (this PR):Could not find both visual-plan and visual-recap skills — none of the candidates match

The repo's authoritative doc, .agents/skills/adding-a-skill/SKILL.md, pins the sibling checkout at ../agent-native/framework (e.g. "visual-plan and visual-recap have generated/synced copies between this repo and ../agent-native/framework"). So npm run check failing for you looks like a layout difference — your agent-native clone puts the plugin at the repo root rather than under framework/ — rather than a wrong default.

Rather than swapping one hardcoded base for another (which just moves the breakage to the other layout), could we try both bases so either checkout works without needing AGENT_NATIVE_FRAMEWORK_PATH?

const defaultFrameworkPaths = [
  path.resolve(repoRoot, "../agent-native/framework"),
  path.resolve(repoRoot, "../agent-native"),
];

…then fall through them in resolution (first that resolves wins). That keeps your setup working without regressing the documented one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants