Skip to content

Fix recording pill bugs in Clips desktop#2118

Merged
shomix merged 2 commits into
mainfrom
shomix-p-meetings-fixes-2
Jul 14, 2026
Merged

Fix recording pill bugs in Clips desktop#2118
shomix merged 2 commits into
mainfrom
shomix-p-meetings-fixes-2

Conversation

@shomix

@shomix shomix commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Reduced the number of threads used for on-device transcription from 4 to 2. This should lower the CPU resources Clips uses while transcribing. I checked locally and didn't notice any performance loses

The recording pill broke when you clicked the tray icon while it was expanded. The pill window would shrink back to its collapsed size, but its content still showed the expanded layout, making it look squished and broken. The pill now stays the correct size no matter how many times the tray icon is clicked.

image

The recording pill reset itself every time you clicked the tray icon during a meeting. The timer jumped back to 0 and the live transcript disappeared, even though the meeting was still recording. The pill now only resets when a new meeting actually starts, so an in-progress meeting keeps its timer, transcript, and notes intact.

@netlify

This comment has been minimized.

@netlify

This comment has been minimized.

@netlify

This comment has been minimized.

@netlify

This comment has been minimized.

@netlify

This comment has been minimized.

@netlify

This comment has been minimized.

@netlify

This comment has been minimized.

@netlify

This comment has been minimized.

@netlify

This comment has been minimized.

@netlify

This comment has been minimized.

@netlify

This comment has been minimized.

@netlify

This comment has been minimized.

@github-actions

github-actions Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Here's a visual recap of what changed:

Visual recap

Open the full interactive recap

builder-io-integration[bot]

This comment was marked as outdated.

@builder-io-integration builder-io-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builder reviewed your changes — looks good ✅

Review Details

Incremental Code Review Summary

The latest commit adds PILL_EXPANDED.store(false, Ordering::SeqCst) when detached mode forces the pill to collapse. This directly fixes the previously reported stale native expanded-state issue, so that open review comment was resolved before this review. Two independent review agents found no new confirmed bugs in the updated recording-pill lifecycle, tray re-show sizing, same-session context guard, detached transitions, or macOS transcription thread reduction.

The implementation now keeps the Rust sizing mirror aligned with the renderer during detach, avoids resetting timer/transcript/notes for repeated same-session tray events, and preserves the intended CPU optimization. This remains a standard-risk native/UI state change.

🧪 Browser testing: Attempted after this review, but Chrome automation was unavailable. The changed recording-pill and tray flows are Tauri-native and cannot be reached through the /clips web app; native desktop verification is still required for visual confirmation.

@shomix shomix merged commit 3889a59 into main Jul 14, 2026
92 checks passed
@shomix shomix deleted the shomix-p-meetings-fixes-2 branch July 14, 2026 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants