Skip to content

Clips: Stop re-prompting users to download the desktop app#2116

Merged
shomix merged 2 commits into
mainfrom
shomix-p-meeting-notif-2
Jul 14, 2026
Merged

Clips: Stop re-prompting users to download the desktop app#2116
shomix merged 2 commits into
mainfrom
shomix-p-meeting-notif-2

Conversation

@shomix

@shomix shomix commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Once someone downloads the Clips desktop installer, we no longer nag them to do it again. We also cleaned up a duplicate desktop app prompt and made the sidebar prompt fill the full width of the sidebar.

Changes

  • Downloading the desktop app now marks it as installed, so the "Get desktop app" prompts stop showing up afterward instead of reappearing on every visit.
  • Removed a second, redundant "Get desktop app" prompt from the meetings pages && dictate pages since the same prompt already appears at the top of the page.
  • The "Get desktop app" link in the library sidebar now spans the full width of the sidebar instead of shrinking to fit its text.

@netlify

This comment has been minimized.

@netlify

This comment has been minimized.

@netlify

This comment has been minimized.

@netlify

This comment has been minimized.

@netlify

This comment has been minimized.

@netlify

This comment has been minimized.

@netlify

This comment has been minimized.

@netlify

This comment has been minimized.

@netlify

This comment has been minimized.

@netlify

This comment has been minimized.

@netlify

This comment has been minimized.

@netlify

This comment has been minimized.

@github-actions

github-actions Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Here's a visual recap of what changed:

Visual recap

Open the full interactive recap

builder-io-integration[bot]

This comment was marked as outdated.

@builder-io-integration builder-io-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builder reviewed your changes and found 1 potential issue 🟡

Review Details

Incremental Code Review Summary

The latest commit removes several redundant desktop-app prompts from Dictate, meeting detail, and the meetings page, while retaining the shared localStorage tracking and sidebar layout changes. Those removals reduce duplicate prompting, but the previously reported core issue remains open: shouldShowSidebarLink still ignores the downloaded marker, so the library sidebar CTA (and the unchanged record surface) can continue prompting after installation. I have not resubmitted that existing finding.

New Findings

🟡 MEDIUM — Dictate still renders its desktop-app promotional card for non-desktop users, but this commit removes the card’s only install action, leaving a dead-end callout on normal non-empty Dictate pages.

LOW — The fallback GitHub release-page links on /download do not mark the installer as downloaded, so successful fallback installs can continue showing prompts. This is included for completeness and may be filtered by review risk.

The localStorage helpers remain defensive, direct asset links are tracked, and the meetings prompt cleanup is directionally sound.

🧪 Browser testing: Will run after this review (PR touches UI code)

Comment thread templates/clips/app/routes/_app.dictate.tsx

@steve8708 steve8708 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great idea

@shomix shomix merged commit a87e178 into main Jul 14, 2026
89 checks passed
@shomix shomix deleted the shomix-p-meeting-notif-2 branch July 14, 2026 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants