Clips: Stop re-prompting users to download the desktop app#2116
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Here's a visual recap of what changed: Open the full interactive recap |
There was a problem hiding this comment.
Builder reviewed your changes and found 1 potential issue 🟡
Review Details
Incremental Code Review Summary
The latest commit removes several redundant desktop-app prompts from Dictate, meeting detail, and the meetings page, while retaining the shared localStorage tracking and sidebar layout changes. Those removals reduce duplicate prompting, but the previously reported core issue remains open: shouldShowSidebarLink still ignores the downloaded marker, so the library sidebar CTA (and the unchanged record surface) can continue prompting after installation. I have not resubmitted that existing finding.
New Findings
🟡 MEDIUM — Dictate still renders its desktop-app promotional card for non-desktop users, but this commit removes the card’s only install action, leaving a dead-end callout on normal non-empty Dictate pages.
LOW — The fallback GitHub release-page links on /download do not mark the installer as downloaded, so successful fallback installs can continue showing prompts. This is included for completeness and may be filtered by review risk.
The localStorage helpers remain defensive, direct asset links are tracked, and the meetings prompt cleanup is directionally sound.
🧪 Browser testing: Will run after this review (PR touches UI code)

Once someone downloads the Clips desktop installer, we no longer nag them to do it again. We also cleaned up a duplicate desktop app prompt and made the sidebar prompt fill the full width of the sidebar.
Changes
meetings pages&&dictate pagessince the same prompt already appears at the top of the page.