Redesign generation results as library-style asset grid#2115
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Here's a visual recap of what changed: Open the full interactive recap |
|
@builderio-bot look at latest PR feedback and fix anything you agree with. Be skeptical. Reply to every comment (directly on the comment thread of each comment) if you fixed it or not and why. then check back every 2 minutes on a loop and see if any new feedback posted, until at least 20 minutes go by without any new feedback posted we want to address, including making sure CI passes too and no merge conflicts (make sure code is mergeable) |
|
Went through both automated review rounds (in reply to #2115 (review) and #2115 (review)). Fixed what I agreed with, pushed back on one point: ✅ Fixed — non-ready candidates had no touch-accessible dismiss path ✅ Fixed — preview dialog had no delete action ✅ Fixed — "View details" left the preview dialog open behind the navigated page ↩️ Pushed back — ready-card quick actions (Save/Refine/Delete) staying hover-only on the grid Also fixed (found separately, was failing CI) |
|
Re: #2115 (review) — this review ran against the previously-pushed commit ( |
|
There was a problem with your request, please try again later. Error id: |
There was a problem hiding this comment.
Builder reviewed your changes and has a few items to flag 🟡
Review Details
Incremental Code Review Summary
The latest commit addresses the previously reported modal-persistence issue by closing the preview before View details navigation, makes non-ready dismissal directly available, adds dismiss to the preview dialog, and adds the Traditional Chinese variant label. These changes improve the affected flows and no regressions were found in the save/refine/dismiss state wiring.
One new UX issue remains: pending and failed cards render their full image area as an enabled-looking button, but clicking it is a no-op because preview activation is gated on ready. This gives users no feedback that the card cannot be opened and is especially confusing alongside the visible status badge.
🧪 Browser testing: Attempted full verification, but browser automation tooling remained unavailable. The dev server also required a restart after setup and was still warming/connecting during the verification window, so no visual evidence was collected.
|
awesome, very nice @SajalChaplot! |

Summary
Reworks the in-chat generation results UI to match the drafts grid used in the Library section, replacing the old list-style candidate cards with a hover-driven asset grid and a full preview dialog.
Problem
The previous generation results view showed candidates as stacked cards with always-visible action buttons and text labels, which was inconsistent with the drafts UI already used in the Library, and lacked a way to preview a generated asset before deciding to save it.
Solution
Introduced a
GenerationDraftCardgrid layout consistent with the library drafts UI, along with aGenerationPreviewDialogfor viewing an individual generated asset within the chat, keeping scope limited to assets generated in that thread.https://clips.agent-native.com/share/uTC0NI2V0KEA?ref=clip_share
Key Changes
GenerationResultItemlist cards withGenerationDraftCard, rendered in a responsiveassets-library-grid(2/3 columns) instead of the previous 1/2-column list layout.GenerationPreviewDialog(usingDialog/DialogContent) to open a full-size preview of a slot, with save, refine, view details, and close actions.saveSlot,dismissSlotById, andrefineSlothandlers used by both the grid cards and the preview dialog to avoid duplicated mutation logic.VariantSlottype alias forAssetVariantState["slots"][number]to simplify typing across the file.GenerationSlotPreviewthumbnail to add a subtle hover scale transition.To clone this PR locally use the Github CLI with command
gh pr checkout 2115You can tag me at @BuilderIO for anything you want me to fix or change