Skip to content

Fix configurable visual recap runner shell#2097

Open
CheckPickerUpper wants to merge 1 commit into
BuilderIO:mainfrom
CheckPickerUpper:feat/self-hosted-visual-recap
Open

Fix configurable visual recap runner shell#2097
CheckPickerUpper wants to merge 1 commit into
BuilderIO:mainfrom
CheckPickerUpper:feat/self-hosted-visual-recap

Conversation

@CheckPickerUpper

@CheckPickerUpper CheckPickerUpper commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Follow-up to #2038 and #2046.

What changed

  • run the configurable recap jobs with an explicit Bash shell
  • keep the core compatibility bundle and extracted recap CLI bundle byte-identical to the canonical workflow
  • cover the copied, reusable, and extracted-package workflows with regression assertions
  • add patch changesets for @agent-native/core and @agent-native/recap-cli

Why

The runner configuration accepts GitHub-hosted Windows and macOS labels as well as self-hosted label arrays, but the recap steps use Bash syntax throughout. Without an explicit shell, a valid Windows runner configuration reaches the job and is interpreted by PowerShell. Pinning shell: bash at the job level makes the workflow contract match the configurations setup and doctor already accept.

Verification

  • pnpm --filter @agent-native/recap-cli exec vitest --run src/pr-visual-recap-workflow.spec.ts (2 tests)
  • pnpm --filter @agent-native/core exec vitest --run src/cli/recap.spec.ts --maxWorkers=25% (199 tests)
  • pnpm --filter @agent-native/recap-cli typecheck
  • pnpm --filter @agent-native/core typecheck
  • pnpm guards (23 checks)
  • pnpm exec oxfmt --check ...
  • pnpm changeset status
  • actionlint on both configurable workflows
  • git diff --check

@netlify

This comment has been minimized.

@netlify

This comment has been minimized.

@netlify

This comment has been minimized.

@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Visual recap — skipped

The visual recap job did not run for this pull request. This is informational only and does not block the PR.

Recap skipped for fa22260: external fork PR requires a maintainer to apply the recap label to the current head SHA.

@CheckPickerUpper CheckPickerUpper marked this pull request as ready for review July 13, 2026 17:43

@builder-io-integration builder-io-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builder reviewed your changes — looks good ✅

Review Details

Code Review Summary

PR #2097 adds an explicit bash default shell to the recap job in both the canonical and reusable GitHub Actions workflows, updates the CLI-bundled workflow, and adds regression assertions plus a patch changeset. The approach is sound: the shell is scoped to the recap job rather than the gate job, which preserves runner-selection behavior while ensuring Bash syntax works on Windows, macOS, Linux, and self-hosted labels. The byte-identity regression test also confirms the generated CLI workflow remains synchronized with the canonical checked-in workflow.

No actionable bugs, security issues, performance regressions, or release/changeset problems were confirmed. The targeted recap test suite passed all 198 tests, including the byte-identity and shell assertions. This is a standard-risk infrastructure/workflow change.

🧪 Browser testing: Skipped — PR only modifies workflows, CLI workflow packaging, tests, and a changeset; no user-facing browser impact.

@steve8708

Copy link
Copy Markdown
Contributor

thanks @CheckPickerUpper! just need a merge conflict resolution then this is good to go

@CheckPickerUpper CheckPickerUpper force-pushed the feat/self-hosted-visual-recap branch from c47b454 to fa22260 Compare July 14, 2026 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants