Fix configurable visual recap runner shell#2097
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Visual recap — skippedThe visual recap job did not run for this pull request. This is informational only and does not block the PR. Recap skipped for |
There was a problem hiding this comment.
Builder reviewed your changes — looks good ✅
Review Details
Code Review Summary
PR #2097 adds an explicit bash default shell to the recap job in both the canonical and reusable GitHub Actions workflows, updates the CLI-bundled workflow, and adds regression assertions plus a patch changeset. The approach is sound: the shell is scoped to the recap job rather than the gate job, which preserves runner-selection behavior while ensuring Bash syntax works on Windows, macOS, Linux, and self-hosted labels. The byte-identity regression test also confirms the generated CLI workflow remains synchronized with the canonical checked-in workflow.
No actionable bugs, security issues, performance regressions, or release/changeset problems were confirmed. The targeted recap test suite passed all 198 tests, including the byte-identity and shell assertions. This is a standard-risk infrastructure/workflow change.
🧪 Browser testing: Skipped — PR only modifies workflows, CLI workflow packaging, tests, and a changeset; no user-facing browser impact.
|
thanks @CheckPickerUpper! just need a merge conflict resolution then this is good to go |
c47b454 to
fa22260
Compare
Follow-up to #2038 and #2046.
What changed
@agent-native/coreand@agent-native/recap-cliWhy
The runner configuration accepts GitHub-hosted Windows and macOS labels as well as self-hosted label arrays, but the recap steps use Bash syntax throughout. Without an explicit shell, a valid Windows runner configuration reaches the job and is interpreted by PowerShell. Pinning
shell: bashat the job level makes the workflow contract match the configurations setup and doctor already accept.Verification
pnpm --filter @agent-native/recap-cli exec vitest --run src/pr-visual-recap-workflow.spec.ts(2 tests)pnpm --filter @agent-native/core exec vitest --run src/cli/recap.spec.ts --maxWorkers=25%(199 tests)pnpm --filter @agent-native/recap-cli typecheckpnpm --filter @agent-native/core typecheckpnpm guards(23 checks)pnpm exec oxfmt --check ...pnpm changeset statusactionlinton both configurable workflowsgit diff --check