Fix configurable visual recap runner shell#2097
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Visual recap — skippedThe visual recap job did not run for this pull request. This is informational only and does not block the PR. Recap skipped for |
|
thanks @CheckPickerUpper! just need a merge conflict resolution then this is good to go |
c47b454 to
fa22260
Compare
fa22260 to
ce7e529
Compare
There was a problem hiding this comment.
Builder reviewed your changes — looks good ✅
Review Details
Incremental Code Review Summary
The latest PR head is unchanged from the prior incremental review: it adds synchronized workflow constants to both packages, explicitly selects Bash for recap jobs on configurable runners, and covers the canonical, reusable, core-bundled, and recap-cli-bundled workflows with regression assertions. The package exports and duplicated constants are consistent, and the byte-identity checks protect the installer output from drifting from the canonical workflow.
No new actionable bugs, security issues, performance regressions, or release problems were found. Targeted tests passed again: @agent-native/recap-cli 2/2 and @agent-native/core 199/199. This remains a standard-risk infrastructure/package change.
🧪 Browser testing: Skipped — the PR only changes workflows, package exports, tests, and changesets; there is no user-facing browser impact.
|
Resolved the conflict against current |
Follow-up to #2038 and #2046.
What changed
@agent-native/coreand@agent-native/recap-cliWhy
The runner configuration accepts GitHub-hosted Windows and macOS labels as well as self-hosted label arrays, but the recap steps use Bash syntax throughout. Without an explicit shell, a valid Windows runner configuration reaches the job and is interpreted by PowerShell. Pinning
shell: bashat the job level makes the workflow contract match the configurations setup and doctor already accept.Verification
pnpm --filter @agent-native/recap-cli exec vitest --run src/pr-visual-recap-workflow.spec.ts(2 tests)pnpm --filter @agent-native/core exec vitest --run src/cli/recap.spec.ts --maxWorkers=25%(199 tests)pnpm --filter @agent-native/recap-cli typecheckpnpm --filter @agent-native/core typecheckpnpm guards(23 checks)pnpm exec oxfmt --check ...pnpm changeset statusactionlinton both configurable workflowsgit diff --check