Skip to content

Remove legacy MySQL driver recommendations in DatabaseAutoConfiguration #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
StanislavFedorov wants to merge 1 commit into
base: develop-3.0.x
Choose a base branch
from
Open

Remove legacy MySQL driver recommendations in DatabaseAutoConfiguration #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions src/main/java/com/broadleafcommerce/autoconfigure/DatabaseAutoConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,15 +130,7 @@ protected void logDriverInconsistencies(String explicitDriverClassName, String s
LOG.error("Application did not set property database.driver and Spring wasn't able to derive driver class from url. Set the database.driver property and/or review property database.url to make sure a valid url is set.");
}

if (NEW_MYSQL.equals(explicitDriverClassName)) {
LOG.warn("Application explicitly set the driver class to " + NEW_MYSQL + ". Broadleaf recommends using driver class " + OLD_MYSQL + " as it performs better. Set \"database.driver=" + OLD_MYSQL + "\" to use the more performant driver.");
}

if (explicitDriverClassName == null && NEW_MYSQL.equals(springDriverClassName)) {
LOG.warn("Application did not set property database.driver when using MySQL therefore driver class " + NEW_MYSQL + " will be used per Spring's recommendation. Broadleaf suggests using driver class " + OLD_MYSQL + " as it performs better than " + NEW_MYSQL + ".");
}

if (explicitDriverClassName != null && !explicitDriverClassName.equals(springDriverClassName) && !OLD_MYSQL.equals(explicitDriverClassName)) {
if (explicitDriverClassName != null && !explicitDriverClassName.equals(springDriverClassName) && !NEW_MYSQL.equals(explicitDriverClassName)) {
LOG.warn("Application explicitly set the driver class to " + explicitDriverClassName + " which does not equal Spring's recommended driver class of " + springDriverClassName + ". If this is not on purpose please set the property database.driver to \"database.driver=\" to use Spring's recommended driver.");
}
}
Expand Down