Skip to content

Throw a KeyError exception if obsolete names are used#191

Merged
kbabioch merged 2 commits into
Bouni:mainfrom
Guzz-T:issue/168/obsolete
Oct 24, 2025
Merged

Throw a KeyError exception if obsolete names are used#191
kbabioch merged 2 commits into
Bouni:mainfrom
Guzz-T:issue/168/obsolete

Conversation

@Guzz-T

@Guzz-T Guzz-T commented Nov 20, 2024

Copy link
Copy Markdown
Contributor

Unlike #187, this version no longer supports obsolete names. Instead, it returns an exception, compelling the user to switch to the latest version.

The names are passed directly to the constructor, eliminating the need for additional files or constants. This allows for the identification of names from previous versions without the need to execute the code.

Fixes #168.
Replaces #171 and #187.

@github-actions

github-actions Bot commented Nov 20, 2024

Copy link
Copy Markdown

Coverage

Coverage Report
FileStmtsMissCoverMissing
luxtronik
   __init__.py1841194%42–43, 46–51, 257–258, 263
   __main__.py21210%3–49
   datatypes.py322199%110
   discover.py58198%62
luxtronik/scripts
   dump_changes.py43430%7–85
   dump_luxtronik.py26260%6–52
luxtronik/shi
   definitions.py204399%113, 425–426
   modbus.py105199%320
TOTAL114410791% 

Tests Skipped Failures Errors Time
237 0 💤 0 ❌ 0 🔥 15.676s ⏱️

@Guzz-T

Guzz-T commented Dec 6, 2024

Copy link
Copy Markdown
Contributor Author

@Bouni, @gerw How do you like this proposed solution?

@kbabioch

Copy link
Copy Markdown
Collaborator

For me this seems reasonable and since its configurable, it should make everyone happy. Anyone against merging this, since it has been lying around for quite a while?

@Bouni

Bouni commented Oct 24, 2025

Copy link
Copy Markdown
Owner

LGTM

@kbabioch Feel free to merge this one

@kbabioch

kbabioch commented Oct 24, 2025

Copy link
Copy Markdown
Collaborator

I've rebased it on top current master and self-approved it, since this was a trivial change. Hopefully no one feels offended by this, wanted to proceed with this one, since @Bouni told us that we may proceed in this previous comment.

@kbabioch kbabioch requested review from Bouni and kbabioch October 24, 2025 15:55
@kbabioch kbabioch merged commit 43ca218 into Bouni:main Oct 24, 2025
4 checks passed
@Guzz-T Guzz-T deleted the issue/168/obsolete branch October 24, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Maintain a list of changed parameter/calculation names

3 participants