Add indexed Array.set and fixed-size array constructor#3716
Draft
ATX24 wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Dhilan Shah <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error
A mutable random-write array update was not expressible. Before this change, the smallest
.setrepro failed:Old compiler output:
The requested fixed-size constructor syntax also failed before the change:
Old compiler output:
Root cause
crates/baml_builtins2/baml_std/baml/containers.bamldefinedArray<T>methods such asat,push, andsplice, but did not define an indexedsetmethod or any fixed-size constructor.crates/baml_compiler_parser/src/parser.rsonly treated[]in expression position as array literals or indexing, soint[](6, 0)was parsed as a value pathintfollowed by an invalid empty index expression rather than as an array constructor.crates/baml_compiler2_tir/src/builder.rs::try_container_method_callonly had evolving-container special handling forpush/append, so unannotated arrays could not establish or validate element type through.set.crates/bex_vm/src/package_baml/array.rshad no native runtime implementation for either operation.The fix
Array<T>.set(index: int, value: T) -> null throws baml.errors.InvalidArgumentto the stdlib and implemented it in the VM array package with negative/out-of-bounds validation.Array<T>.new(size: int, default: T) -> T[] throws baml.errors.InvalidArgumentand parser/AST lowering forT[](size, default)as sugar forbaml.Array.new<T>(size, default).let xs = []; xs.set(i, v)type-checks consistently withpush, including index validation asintand value validation against the element type.set, and negative constructor size.Verification
Reproduction after the change:
Output:
Output:
Test commands run from
baml_language/:Note:
sdk_test_typescript_nodeis run with its documented setup split becausesdk_tests/README.mdstates plaincargo testregenerates the TypeScript fixtures without running their setup script.