Add regression tests for concat strings through println and shell#3713
Draft
ATX24 wants to merge 1 commit into
Draft
Add regression tests for concat strings through println and shell#3713ATX24 wants to merge 1 commit into
ATX24 wants to merge 1 commit into
Conversation
Co-authored-by: Dhilan Shah <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
⏭️ Performance benchmarks were skippedPerf benchmarks (CodSpeed) are opt-in on pull requests — they no longer run on every push. They always run automatically after merge to To run them on this PR, do any of the following, then push a commit (or re-run CI):
|
|
No description provided. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error
Claimed regression shape:
The reported incorrect behavior was silent empty shell output after the
printlnconsumption step:The expected shell stdout is non-empty and exactly:
Root cause
No current compiler/runtime bug was reproduced in this branch. The gap was missing CI coverage in
baml_language/crates/baml_tests/tests/shell.rsfor this specific interaction:baml.io.printlnconsumes that same value first,baml.sys.shelllater receives the command string,That left the compiler2 VM/sysop path exercised by
baml_tests::baml_test!without a regression guard for this silent-failure shape.The fix
Added three Unix shell regression tests in
baml_language/crates/baml_tests/tests/shell.rs:baml.io.printlnbeforebaml.sys.shell,printlncalls beforeshell,letbindings with theprintlnresult assigned to_beforeshell.Each test asserts stdout is not empty and equals
"hello_world\n".Verification
Ran from
baml_language/unless noted:cargo fmt cargo test --package baml_tests shell_concat --test shellResult:
cargo test --package baml_tests --test shellResult:
cargo test --package baml_tests --libResult:
Result: completed with exit code 0 after running nextest setup scripts for the SDK fixtures.
Note: plain workspace
cargo testreachedsdk_test_typescript_nodeand failed because the SDK test docs requirecargo nextest runfor setup-script-driven fixture installs; the nextest full-suite run passed.Issue Reference
Changes
baml.io.printlnand then passed tobaml.sys.shell.Testing
PR Checklist
Additional Notes
No legacy
engine/files were modified; all changes are scoped tobaml_language/.