fix: report line-local columns for VM events#3623
Conversation
|
@wuyua9 is attempting to deploy a commit to the Boundary Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThis PR extends debug source mapping to track column offsets alongside line numbers. The compiler now computes 0-indexed columns during line-table generation, stores them in bytecode entries, propagates them through compact bytecode, and uses them in VM event emission. ChangesColumn Offsets in Source Location Tracking
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
SendEventsource locations while keeping start/end offsets unchangedTests
rustfmt --edition 2024 baml_language/crates/baml_compiler2_emit/src/emit.rs baml_language/crates/bex_vm/src/vm.rs baml_language/crates/bex_vm_types/src/bytecode.rsgit diff --checkcargo test -p bex_vm_types line_table_translated --manifest-path baml_language/Cargo.tomlcannot link in this local macOS environment becausexcrunfails to load the installed CommandLineToolslibxcrun.dylibas arm64/arm64e while compiling build scripts.Summary by CodeRabbit