feat(DockView): preventing access to objects after dispose

[ArgoZhang]

Link issues

fixes #1053

Summary By Copilot

Regression?

• Yes
• No

Risk

• High
• Medium
• Low

Verification

• Manual (required)
• Automated

Packaging changes reviewed?

• Yes
• No
• N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

• Doc is updated/provided or not needed
• Demo is updated/provided or not needed
• Merge the latest code from the main branch

Summary by Sourcery

Bug Fixes:

• Prevent DockViewV2 from invoking JS initialization or post-render logic after the component has been disposed.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds a disposal guard to DockViewV2 to prevent JS interop and render logic from running after the component has been disposed, avoiding access to invalid objects.

Sequence diagram for DockViewV2 disposal guard behavior

sequenceDiagram
    participant Blazor
    participant DockViewV2

    Blazor->>DockViewV2: OnAfterRenderAsync(firstRender)
    alt _disposed is false
        DockViewV2->>DockViewV2: set _layoutConfig
        DockViewV2->>DockViewV2: InvokeInitAsync()
        alt _disposed is false
            DockViewV2->>JSRuntime: InvokeVoidAsync(init, Id, Interop, GetDockViewConfig)
        else _disposed is true
            DockViewV2-->>Blazor: Task.CompletedTask
        end
    else _disposed is true
        DockViewV2-->>Blazor: return
    end

    Blazor->>DockViewV2: DisposeAsync(disposing: true)
    DockViewV2->>DockViewV2: _disposed = true
    DockViewV2->>ThemeProviderService: unsubscribe OnThemeChangedAsync
    DockViewV2-->>Blazor: dispose complete

Loading

File-Level Changes

Change	Details	Files
Introduce a disposal state flag and guard lifecycle/interop methods to no-op after disposal.	Add a private _disposed boolean field to track component disposal state. Set _disposed to true inside DisposeAsync when disposing is true before unsubscribing from ThemeProviderService.ThemeChangedAsync. Short‑circuit OnAfterRenderAsync to return immediately when _disposed is true, preventing further post-render logic after disposal. Update InvokeInitAsync to return a completed task without invoking JS interop when _disposed is true, avoiding initialization after disposal.	src/components/BootstrapBlazor.DockView/Components/DockViewV2.razor.cs

Assessment against linked issues

Issue	Objective	Addressed	Explanation
#1053	Prevent DockViewV2 from accessing or using its internal objects/state after the component has been disposed.	✅

Possibly linked issues

• feat(DockView): preventing access to objects after dispose #1053: PR adds a _disposed flag and guards init/render methods, directly implementing the requested post-dispose access prevention.
• feat(DockView): preventing access to objects after dispose #1053: PR adds a _disposed flag and guards methods in DockViewV2, implementing the requested disposing logic.
• feat(DockView): preventing access to objects after dispose #1053: The PR adds a _disposed guard to stop init/render after dispose, resolving the DockView dispose exception.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[bb-auto]

Auto approved by bb-auto

[sourcery-ai]

Hey - I've left some high level feedback:

• In OnAfterRenderAsync, the _disposed check happens only after base.OnAfterRenderAsync is awaited; if a render is triggered after disposal, the base implementation will still run, so consider short-circuiting before calling the base method to avoid any post-dispose work entirely.
• Now that _disposed is used to guard JS interop in OnAfterRenderAsync and InvokeInitAsync, review other JS interop or async callbacks in this component to ensure they also check _disposed for consistent behavior after disposal.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- In `OnAfterRenderAsync`, the `_disposed` check happens only after `base.OnAfterRenderAsync` is awaited; if a render is triggered after disposal, the base implementation will still run, so consider short-circuiting before calling the base method to avoid any post-dispose work entirely.
- Now that `_disposed` is used to guard JS interop in `OnAfterRenderAsync` and `InvokeInitAsync`, review other JS interop or async callbacks in this component to ensure they also check `_disposed` for consistent behavior after disposal.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}