feat(assistant-editor): group knowledge base into a contrasted inset panel#557
Merged
Merged
Conversation
…panel Wrap the Knowledge base section on the Assistant editor in a rounded, bordered inset with a subtle gray-100/60 fill instead of the flat border-t divider shared by other sections. Against the gray-50 form column this reads as a mildly contrasted group, and the white inner lists (Web sources / Uploaded Documents) now float on the tint to reinforce the grouping. Drops the border-t/pt-8 divider since the card provides its own separation; the form's space-y-8 preserves the top gap. Co-Authored-By: Claude Opus 4.8 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Visually distinguishes the Knowledge base section on the Assistant editor by wrapping it in a mildly contrasted, grouped inset panel instead of the flat
border-tdivider used by every other section.Why
The Knowledge base area is the densest, most interactive part of the editor (uploads, connectors, web crawls, sync controls). Giving it a grouped container makes it read as a distinct workspace rather than one more divider-separated block.
Changes
Single-line class change on the
<section>inassistant-form.page.html:space-y-4 border-t border-gray-200 pt-8 dark:border-gray-700space-y-4 rounded-2xl border border-gray-200 bg-gray-100/60 p-5 dark:border-gray-700 dark:bg-gray-800/40 sm:p-6Reviewer notes
bg-gray-50, so agray-100/60fill is a deliberately mild contrast step — grouped, not loud.bg-white, so they now float on the tint, reinforcing the grouping.border-t/pt-8divider was dropped because the card provides its own separation; the form'sspace-y-8preserves the gap above it.dark:bg-gray-800/40over thegray-900column for the same subtle lift.rounded-2xl,border-gray-200,dark:border-gray-700) match the editor's existing list/dialog idiom.🤖 Generated with Claude Code