Fix gen-docs CI: run protoc-gen-doc on host instead of stale container#274
Merged
Conversation
The gen-docs workflow ran inside pseudomuto/protoc-gen-doc:1.5.1, whose ~4-year-old Alpine/musl base can no longer host the Node 24 binary the runner injects for JS actions (actions/checkout), so the job died at checkout with: Error relocating .../node24_alpine/bin/node: pthread_getname_np: symbol not found Drop the container and install protoc + protoc-gen-doc directly on ubuntu-latest (Option 1 from #271). protoc-gen-doc is pinned to v1.5.1 to match the previous container, so the generated HTML is identical. Go's bin dir is added to PATH so protoc can find the plugin. Fixes #271 Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #271
Problem
The
Generate documentationworkflow fails on every push tomaster, at the Checkout source step — before any docs are generated. It runs insidecontainer: pseudomuto/protoc-gen-doc:1.5.1, whose ~4-year-old Alpine/musl base can no longer host the Node binary GitHub injects to run JS actions (actions/checkout). With Node 20 being deprecated, the runner now injects Node 24, which needspthread_getname_np(musl ≥ 1.2.3):Bumping
actions/checkoutdoesn't help — the failing binary is the runtime the runner injects, not the action's code.Fix (Option 1 from the issue)
Drop the container and install the toolchain directly on
ubuntu-latest:protocvia apt (protobuf-compiler)protoc-gen-docviago install …@v1.5.1(Go is preinstalled on runners)$(go env GOPATH)/binto$GITHUB_PATHsoprotocfinds the pluginprotoc-gen-docis pinned to v1.5.1 — the same version as the old container — so the generated HTML is identical. The doc-generation command, triggers, secrets, and Azure upload (container: protocoldefinitions, artifactdocs) are unchanged.Also removed the leftover debug steps (
Print path,List files,List doc files).Why not the alternatives
buf.yaml/buf.gen.yaml) — out of scope for a CI hotfix.ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSIONstopgap: Node 20 is on a removal path; only buys time.Validation
master), so it will be exercised once merged.🤖 Generated with Claude Code