fix(release): finish the 1.8.1 bump — VERSION and __init__.py were left at 1.8.0#29
Merged
Merged
Conversation
…ft at 1.8.0 a762ab3 bumped pyproject.toml alone, so main shipped with three disagreeing version declarations and test_version_consistency red on both assertions. This is the 1.4.6 failure again: that release bumped pyproject.toml and missed __init__.py, installed copies under-reported __version__, and it could not be corrected afterward because PyPI does not allow overwriting a published file. The guard test exists because of that incident and it caught this one. Publish from main before this lands and 1.8.1 reports __version__ == "1.8.0" forever. Also adds the 1.8.1 CHANGELOG entry, which the release commit omitted. Scoped to what 1.8.1 actually contains: the max_tokens bound and its error message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main is red.
a762ab3("release: 1.8.1") bumped onlypyproject.toml.pyproject.tomlVERSIONblockrun_llm/__init__.pytests/unit/test_version_consistency.pyfails on both assertions atorigin/main.Why this is urgent
This is the 1.4.6 failure repeating. That release bumped
pyproject.tomland missed__init__.py; installed copies under-reported__version__, and it was uncorrectable after the fact because PyPI does not permit overwriting a published artifact. The guard test was added in response to that incident, and it caught this one.If
twine uploadruns frommainbefore this lands, 1.8.1 goes to PyPI reporting__version__ == "1.8.0"permanently.This PR
VERSION→ 1.8.1__init__.py→ 1.8.1max_tokensbound from fix(validation): stop capping max_tokens below what models actually serve #27 and its error message from test: assert the max_tokens error names the SDK's own number #28).373 tests pass;
blackandruffclean.