refactor(wallet): delegate resolution to @blockrun/core#13
Draft
KillerQueen-Z wants to merge 1 commit into
Draft
refactor(wallet): delegate resolution to @blockrun/core#13KillerQueen-Z wants to merge 1 commit into
KillerQueen-Z wants to merge 1 commit into
Conversation
Contributor
|
审了一遍,这个 PR 不能合 —— 它改了「哪把私钥签支付」,而根因在依赖包 行为倒转,不是重构场景:
这是签 x402 支付用哪把私钥的相反答案。 根因在 core,不在接线我先怀疑是 core 的注释自称「Canonical BlockRun order, matching @blockrun/llm's getOrCreateWallet」,但它把 provider 钱包排在了 与既有的刻意修复冲突这个正典是被专门确立并测试过的:
另外两个观察
我没有改动这个分支,把判断留给你 —— 因为「默认用哪个钱包付钱」是产品决策,而修复点在另一个仓库。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Makes
@blockrun/llmthe first shared SDK consumer of@blockrun/core.@blockrun/core@^0.0.3.getOrCreateWallet, andgetWalletAddressto the shared kernel.unchanged.
env → provider wallet.json → ~/.blockrun/.session → legacy wallet.key.Why
Franklin and MCP already consume this SDK. Once this merges, their wallet
resolution automatically shares the same source of truth as the official
blockrunCLI and clawrouter-codex, without any forced migration for users.Lockfile note
package-lock.jsonis regenerated because the upstream lockfile's root packagemetadata was already behind the current
package.json. The large lockfile diffaligns it with the declared dependency versions and adds the published core
package; it does not alter the SDK API surface.
Validation
npm run build— passed.HOME=/tmp/blockrun-llm-test-home npm test— 200 passed, 12 productionintegration tests skipped by design, TypeScript type checks passed.