docs: correct the n-bound rationale — no USDC was ever at risk#24
Merged
Conversation
0.7.2 shipped saying an out-of-range `n` "took payment, then 400'd at the provider and lost the prepaid USDC". That is wrong. BlockRun's gateways settle on success: settlePaymentWithRetry runs after the upstream call, so a request that dies at the provider settles nothing and costs the caller nothing. I inherited the claim from the reviewer and from the t2i schema's own comment, and repeated it without checking the settle ordering — the same mistake the SDK's "API error after payment" wording keeps producing (fixed in blockrun-llm#25). The bound stays. It saves a pointless signed round-trip, a facilitator verify, and an upstream call, and answers 400 locally instead of surfacing the provider's error late. It just was never about losing money, and a changelog that cries wolf about funds is worse than one that says nothing. Docs + comments only; no behavior change. PyPI renders README.md rather than CHANGELOG.md, so the published 0.7.2 description never carried the claim and this needs no republish.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0.7.2 shipped a claim that isn't true. Correcting the record.
What was wrong
The changelog said an out-of-range
n"took payment, then 400'd at the provider and lost the prepaid USDC."BlockRun's gateways settle on success —
settlePaymentWithRetryruns after the upstream call — so a request that dies at the provider settles nothing and costs the caller nothing. I inherited the claim from a reviewer and from the t2i schema's own comment, and repeated it without checking the settle ordering.That's the same mistake the SDK's
"API error after payment"wording keeps producing: it reads as funds gone on failures that took nothing, and it has now misled two reviewers and me (fixed in BlockRunAI/blockrun-llm#25).What stays
The
nbound. It saves a pointless signed round-trip, a facilitator verify, and an upstream call, and answers 400 locally instead of surfacing the provider's error late. It just was never about losing money — and a changelog that cries wolf about funds is worse than one that says nothing.Scope
Docs and comments only; no behavior change. 277 tests pass.
PyPI renders
README.mdrather thanCHANGELOG.md, so the published 0.7.2 description never carried the claim — no republish needed. The corrected text ships with the next release.Related