chore(deps): npm update, with two pins that would otherwise break the build#116
Open
VickyXAI wants to merge 1 commit into
Open
chore(deps): npm update, with two pins that would otherwise break the build#116VickyXAI wants to merge 1 commit into
VickyXAI wants to merge 1 commit into
Conversation
… build
`npm update` refreshed the semver-compatible range of every dependency and
pruned a large amount of stale transitive lockfile state (net -1296 lines).
`@blockrun/llm` moved 3.5.2 -> 3.8.3, which includes this session's max_tokens
guard fix.
Two packages had to be constrained because a plain update broke a green build,
and both failures were invisible to `npm test` on its own — the suite runs the
already-emitted dist, so a tsc failure and a runtime resolution failure both
passed the test gate while `npm run build` exited non-zero. Verified by
checking the build exit code directly, not the test result.
- @types/ws: update pulled it 7.4.7 -> 8.18.1 (a major). Under 8's types,
`import WebSocket from 'ws'; new WebSocket.Server(...)` in src/serve/server.ts
is a TS2339 — `.Server` moved to a named `WebSocketServer` export that does
not exist in 7. Fixing the source ties it to one major or the other, so the
cleaner fix is to pin the types: added `@types/ws: ^7.4.7` (it was an
unconstrained transitive dep, which is why update was free to jump it).
- @colbymchenry/codegraph: update moved 0.9.7 -> 0.9.9, which added an
`exports` map exposing only "." and "./package.json". Franklin resolves the
shim with `require.resolve('@colbymchenry/codegraph/npm-shim.js')`
(src/mcp/codegraph.ts:40); under the new map that subpath is no longer
exported, so resolution throws, getCodegraphServerConfig returns null, and
the built-in CodeGraph MCP server silently disappears. Pinned to an exact
0.9.7 until the shim path is reachable again or the resolve is updated.
build exits 0, tsc clean, 640 pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm updaterefreshed the semver-compatible range of every dependency and pruned a large amount of stale transitive lockfile state (net -1296 lines).@blockrun/llmmoved 3.5.2 → 3.8.3, which includes this session'smax_tokensguard fix.Two packages had to be pinned — and both failures were invisible to
npm testThis is the part worth reading.
npm testruns the already-emitteddist/, so atscfailure and a runtime resolution failure both sailed through the test gate whilenpm run buildwas exiting non-zero. I only caught them by checking the build exit code directly. A greennpm testis not a green build.@types/ws7.4.7 → 8.18.1 (a major)Under 8's types,
import WebSocket from 'ws'; new WebSocket.Server(...)insrc/serve/server.tsis aTS2339—.Serverbecame a namedWebSocketServerexport that does not exist in 7. Fixing the source binds it to one major or the other. Cleaner to pin the types: added@types/ws: ^7.4.7. It was an unconstrained transitive dep, which is exactly whyupdatefelt free to jump it a major.@colbymchenry/codegraph0.9.7 → 0.9.90.9.9 added an
exportsmap exposing only"."and"./package.json". Franklin resolves the built-in MCP shim withrequire.resolve('@colbymchenry/codegraph/npm-shim.js')(src/mcp/codegraph.ts:40). Under the new map that subpath is no longer exported → resolution throws →getCodegraphServerConfigreturnsnull→ the built-in CodeGraph MCP server silently disappears. Pinned to exact0.9.7.Net package.json change
Two lines, both defensive, both with a failing build behind them.
Verification
npm run buildexits 0,tsc --noEmitclean, 640 pass. Checked the build exit code, not just the test result — that distinction is the whole point of this PR.