Skip to content

revert(sdk-coin-hbar): remove self-transfer fallback from PR #8742#8798

Merged
Doddanna17 merged 1 commit into
masterfrom
SI-605-revert-hbar-claim-rewards-self-transfer
May 19, 2026
Merged

revert(sdk-coin-hbar): remove self-transfer fallback from PR #8742#8798
Doddanna17 merged 1 commit into
masterfrom
SI-605-revert-hbar-claim-rewards-self-transfer

Conversation

@Doddanna17
Copy link
Copy Markdown
Contributor

@Doddanna17 Doddanna17 commented May 19, 2026

Summary

  • Reverts PR test(hbar): add unit tests for CoinTransferBuilder self-transfer #8742 (merge commit c1af2989bb) which added getTransferData() self-transfer fallback and unit tests for HBAR claim rewards
  • HBAR claim rewards feature is not being supported -- reverting all related SDK changes
  • This is part of a series of reverts across BitGoJS, bitgo-microservices, and staking-service

PRs being reverted for HBAR claim rewards

Repo PR Status
BitGoJS #8774 (buildTransferData merge) Reverted via #8795 (merged)
BitGoJS #8742 (self-transfer fallback) This PR
BitGoJS #8784 (sdk-core skip validation) Open, will be closed
bitgo-microservices TBD Next
staking-service TBD Next

Test plan

  • Existing HBAR unit tests pass (no claim rewards dependency)
  • CI passes

Ticket: SI-605

@Doddanna17
revert(sdk-coin-hbar): remove self-transfer fallback from PR #8742
dc901cc 
HBAR claim rewards feature is not being supported. Revert the
getTransferData() self-transfer fallback and associated unit tests
added in PR #8742 for SI-539.

This reverts merge commit c1af298.

Ticket: SI-605
@linear-code
Copy link
Copy Markdown

linear-code Bot commented May 19, 2026

SI-605

@Doddanna17 Doddanna17 marked this pull request as ready for review May 19, 2026 07:40
@Doddanna17 Doddanna17 requested a review from a team as a code owner May 19, 2026 07:40
ashutoshkumar-6
ashutoshkumar-6 approved these changes May 19, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@ashutoshkumar-6 ashutoshkumar-6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Doddanna17 Doddanna17 merged commit 9155859 into master May 19, 2026
22 checks passed
@Doddanna17 Doddanna17 mentioned this pull request May 19, 2026
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashutoshkumar-6 ashutoshkumar-6 ashutoshkumar-6 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Doddanna17 @ashutoshkumar-6