fix(statics): add LIQUID_STAKING feature to HypeEVM staking tokens#8787
Closed
bitgo-ai-agent-dev[bot] wants to merge 1 commit into
Closed
fix(statics): add LIQUID_STAKING feature to HypeEVM staking tokens#8787bitgo-ai-agent-dev[bot] wants to merge 1 commit into
bitgo-ai-agent-dev[bot] wants to merge 1 commit into
Conversation
Add CoinFeature.LIQUID_STAKING to hypeevm:hwhype (Hyperwave HYPE) and hypeevm:khype (Kinetiq Staked HYPE). Without this flag, the backend cannot identify these as liquid staking derivatives and fails to link the HYPE debit with the hwHYPE/kHYPE credit during pending approval, causing the wallet balance to appear doubled in the UI. The OFC counterparts (ofchypeevm:hwhype, ofchypeevm:khype) inherit the feature automatically via getFilteredFeatures in ofc.ts. Also adds DEFAULT_FEATURES_EXCLUDE_SINGAPORE to hwhype for consistency with khype, since both are staking products excluded from Singapore custody. Ticket: CECHO-739 Co-Authored-By: Claude Opus 4.7 <[email protected]> Session-Id: 6e731a38-0e23-44db-9371-e3fcaf8e30fc Task-Id: 734ee077-e571-4848-bee2-4cbf7ed7921c
bitgo-ai-agent-dev
Bot
force-pushed
the
dinshawkothari/cecho-739-hypeevm-liquid-staking-feature
branch
from
114c8e9 to
622ab3b
Compare
Contributor
|
Not required. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CoinFeature.LIQUID_STAKINGtohypeevm:hwhype(Hyperwave HYPE) andhypeevm:khype(Kinetiq Staked HYPE) token definitionsofchypeevm:hwhype,ofchypeevm:khype) automatically inherit the feature viagetFilteredFeaturesinofc.ts— no separate change neededDEFAULT_FEATURES_EXCLUDE_SINGAPOREtohwhypefor consistency withkhype(both are staking products excluded from Singapore custody)Test plan
hypeevm:hwhypeandhypeevm:khypehaveCoinFeature.LIQUID_STAKING(new unit tests added)ofchypeevm:hwhypeandofchypeevm:khypeinheritCoinFeature.LIQUID_STAKING(new unit tests added)yarn run unit-test --scope @bitgo/statics— all 28,319 tests passFixes: CECHO-739
🤖 Generated with Ralph