feat(trx): add AccountCreateContract tx builder#8773
Open
bhavidhingra wants to merge 1 commit into
Open
Conversation
2d685ce to
07bbc63
Compare
ranga-r2
previously approved these changes
May 18, 2026
|
|
||
| initBuilder(rawTransaction: TransactionReceipt | string): this { | ||
| this.transaction = this.fromImplementation(rawTransaction); | ||
| this.transaction.setTransactionType(this.transactionType); |
Contributor
There was a problem hiding this comment.
should this come after line 75?
Contributor
Author
There was a problem hiding this comment.
good catch, thanks!
| } | ||
|
|
||
| if (extensionMs > TRANSACTION_MAX_EXPIRATION) { | ||
| throw new ExtendTransactionError('The expiration cannot be extended more than one year'); |
Contributor
There was a problem hiding this comment.
please confirm if one year is correct
Contributor
Author
There was a problem hiding this comment.
this is correct. It is the same implementation as other txn builders of tron
07bbc63 to
6d12524
Compare
Add AccountCreateTxBuilder, ACCOUNT_CREATE_TYPE_URL constant, AccountCreate ContractType enum value, iface types, decode helper, transaction.ts case, wrappedBuilder factory, and unit tests for the new builder. TICKET: CHALO-457
6d12524 to
f827d69
Compare
hrishikeshjain
approved these changes
May 18, 2026
ranga-r2
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AccountCreateTxBuilderfor building TRXAccountCreateContracttransactionsACCOUNT_CREATE_TYPE_URLconstant,AccountCreateContractTypeenum value, iface types, decode helper, andwrappedBuilderfactory integrationTransactionType.AccountCreatetosdk-coreenum for on-chain address activation supportTest plan
modules/sdk-coin-trx/test/unit/transactionBuilder/accountCreateTxBuilder.tsyarn testinmodules/sdk-coin-trxto verify all tests passAccountCreateTxBuildercorrectly encodes/decodesAccountCreateContracttransactionsTICKET: CHALO-457
🤖 Generated with Claude Code