Require BentoBox 3.19.1 at runtime#169
Merged
Merged
Conversation
The 2.10.0 custom block support calls BentoBox hook functionality that is only
available in BentoBox 3.19.1+; on older cores those calls fail. Declare 3.19.1
as the minimum api-version so BentoBox refuses to load the addon on an older
core instead of failing at runtime.
api-version is hardcoded (matching the other addons) rather than filtered from
${bentobox.version}, so the runtime minimum (3.19.1) stays decoupled from the
compile dependency (3.17.0, kept for the Java 21 CI toolchain).
Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
Claude-Session: https://claude.ai/code/session_01AgLXH3e951W2wiUg2BU4WM
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The 2.10.0 custom block support relies on BentoBox hook functionality that is only present in BentoBox 3.19.1+. On an older core those calls fail. This sets the addon's minimum
api-versionto3.19.1so BentoBox refuses to load the addon on an older core rather than failing at runtime.Why hardcoded, not
${bentobox.version}addon.ymlpreviously filteredapi-versionfrom the pom's${bentobox.version}(3.17.0), which is also the compile dependency. Bumping that property to 3.19.1 would break the build — 3.18.x+ artifacts are compiled for Java 25 and can't be read by the Java 21 CI toolchain.Hardcoding
api-version: 3.19.1(as every other BentoBox addon does) decouples the runtime minimum (3.19.1) from the compile dependency (3.17.0), so CI keeps building on Java 21 while servers are correctly required to run BentoBox 3.19.1+.🤖 Generated with Claude Code