php8.5 compat: Add null check for last visited category ID before using it#2
Open
Bashev wants to merge 2 commits into
Open
php8.5 compat: Add null check for last visited category ID before using it#2Bashev wants to merge 2 commits into
Bashev wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If trying to open products directly from homepage (for example) "lastVisitedCategoryId" is empty and this through an error in php8.5 because reflects to nullable array key. As a result product not shown, because check canBeShowInCategory and user see 404.
Description (*)
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Actual result - 404 page (product in our case) not found.
Expected result must be - products is correctly opened.
Questions or comments
Contribution checklist (*)