fix(tui): keep typing while the completion popup has key capture - #17
Merged
Conversation
handleACKey swallowed every key that wasn't a popup navigation key, so once "/" opened the command popup no further input could be typed. Plain keys now fall through to the textarea and re-sync the popup: typing narrows the filter, backspace widens it, a space ends command completion. ctrl+c also quits while the popup is open instead of being dropped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Typing "/" opened the command-completion popup, after which no further characters could be typed — every keystroke that wasn't a popup navigation key was silently swallowed by
handleACKey'sreturn m, nilfallthrough.Fix
Non-navigation keys now fall through to the textarea and re-sync the popup (same path as normal typing):
/→/h→ only/help)ctrl+cquits while the popup is open instead of being droppedTests
TestCommandPopupKeepsTyping(confirmed red before the fix: input stayed "/" after typing "h")make fmt·make vet·make lint(0 issues) ·make test(race, all packages)