fix(tui): drop duplicated in-transcript thinking placeholder - #16
Merged
Conversation
While a streamed assistant turn had no content yet, the transcript rendered a spinner + "thinking…" placeholder line that duplicated the top-bar progress signal (spinner + status + elapsed time). The placeholder is removed and an empty in-flight turn no longer renders a bare odek block at all — the top bar stays the single progress signal and the turn block appears atomically once the first token, reasoning chunk, or tool step arrives.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symptom
While a streamed assistant turn had no visible content yet, two "thinking" signals rendered at once:
⠇ 🧠 thinking · 3s— spinner, context-aware label, elapsed timethinking…placeholder inside the assistant message bodyFix
thinking…placeholder (internal/tui/view.go)⬡ odekblock at all (emptyStreamingTurnguard in the conversation renderer) — no dangling label, no layout jumpThe top bar is now the single progress signal. The turn block appears atomically once the first token, reasoning chunk, or tool step arrives.
Tests (TDD — written red first)
TestEmptyStreamingTurnHidden:thinking…placeholder, no⬡ odekblock in the transcriptthinkingevent → the turn block renders with the reasoning excerptVerification
make fmt && make vet && make lint— 0 issuesmake test— full-racesuite green