In ConfigurGUI restrict SimpleSignals to only emit PySide6 Signals#188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConfigureGUIas getting random segmentation faults when a motor was moving. This was linked back to toMotorSimpleSignalsbeing connected toAxisControlWidget.update_display_of_axis_status. This is inherently an unsafe thread operation since theAxisControlWidgetis running in a thread managed byQt, whereas theSimpleSingalcould have been executed in the thread running theMotor'sasyncioloop.This PR changes what is connected to the
SimpleSignalto only be a Qt signal. Thus, we're triggeringupdate_display_of_axis_statusto run in the Qt thread instead of running it in theasyncioloop thread. This is still inherently not thread safe, but will mitigate the chances of two threads trying to access the same memory space.AxisControlWidget.requestDisplayRefresh.AxisControlWidget.update_display_of_axis_statusfrom its connection toMotor.signals.status_changedandmovement_finished.requestDisplayRefresh.emittoMotor.signals.status_changedandmovement_finished.