Refactor MotionSpaceDisplay in prep for a 3D display#187
Open
rocco8773 wants to merge 75 commits into
Open
Conversation
…e.logger the specific name
…n_list_clear(), animate_motion_pause(), update_canvas(), update_motion_list()
…nimateMotionListPause, animateMotionListClear, updateDisplay, updateDisplayMotionList, updateDisplayPosition, updateDisplayTargetPosition
…ith emitting signal updateDisplayTargetPosition
…tting signal updateDisplayPosition
…itting signal animateMotionListClear
…itting signal animateMotionListPause
… signal animateMotionListStart
…signal updateDisplayMotionList
…they are co-located
…dedicated methods
…nto dedicated methods
…tion into dedicated methods
…into dedicated methods
…e stop the motors and disable controls during a popup
# Conflicts: # bapsf_motion/gui/configure/controllers.py
# Conflicts: # bapsf_motion/gui/configure/motion_builder_overlay.py
…anged, since it is triggered by AxisControlWidget.targetPositionChanged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the
MotionSpaceDisplayfunctionality and its integration with the rest of the GUI architecture in preparation for create a 3D display.