Moodle 501 stable#34
Merged
Merged
Conversation
- Filter out disabled modules - Update get_criteria method signature - Fix code style
This patch reinstates the task from MDL-63260 and MDL-66273.
Limit the fallback placement vertically.
This fixes the CSS rule that reveals the "as new child of" drop target shown when dragging a category over another category which has no children. We can't behat test the actual drag-drop reordering behaviour with behat as reactive DragDrop components aren't testable, but we can trigger the CSS to add a regression test for the drop target's appearance.
This commit improves test_question_shuffle by retrying if questions remains in the same order after shuffling.
…nto MOODLE_501_STABLE
…into MOODLE_501_STABLE
…into MOODLE_501_STABLE
…into MOODLE_501_STABLE
Co-authored-by: Jun Pataleta <[email protected]>
This commit also improves the existing tests and add a new scenario to verify the 'Do not mark for regrade' behavior.
* When testing using phpunit/sqlsrv the ids of sections and cm are colliding so we need to make sure we separate them as a reference to a cm can be the same as a reference to a section
Updated get_users_by_email() to return active users at the start of the returned array, suspended users last.
Added checks to link non-suspended user accounts to OAuth2, when logging in. Also added an additional check to prevent users from using OAuth2 to login if their account is suspended in Moodle.
…into MOODLE_501_STABLE
…into MOODLE_501_STABLE
…/moodle into MOODLE_501_STABLE
…into MOODLE_501_STABLE
…to MOODLE_501_STABLE
…odle into MOODLE_501_STABLE
…into MOODLE_501_STABLE
… MOODLE_501_STABLE
…t/moodle-install into MOODLE_501_STABLE
…into MOODLE_501_STABLE
…-hoogeveen/moodle into MOODLE_501_STABLE
…into MOODLE_501_STABLE
Editing maxmarks in quiz slots was not respecting the decimal separator from the set language's locale, meaning if your language formats numbers like 1,10 editing didn't work correctly. This sets the correct parameter to ensure the locale is respected.
…into MOODLE_501_STABLE
…into MOODLE_501_STABLE
…/moodle into MOODLE_501_STABLE
…into MOODLE_501_STABLE
…into MOODLE_501_STABLE
…into MOODLE_501_STABLE
…odle into MOODLE_501_STABLE
… MOODLE_501_STABLE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.