Add ClusterIP service routing health check - #1302
Merged
Merged
Conversation
Validates ClusterIP service routing by deploying a backend and reaching it from a disposable client pod.
xinWeiWei24
requested review from
Liyu Ma (liyu-ma),
Vittoria (vittoriasalim) and
Lei Yao (wonderyl)
as code owners
August 25, 2026 01:25
|
For reviewers only: reply |
Liyu Ma (liyu-ma)
approved these changes
Aug 25, 2026
| # kube-proxy: a ClusterIP service is reachable from within the cluster, | ||
| # exercising service routing. For daemonset/pod health, pair with | ||
| # ValidateWorkloadHealth(kind="daemonset", name="kube-proxy", namespace="kube-system") | ||
| # only on clusters that run kube-proxy; skip it when a replacement (e.g. Cilium |
Collaborator
There was a problem hiding this comment.
does it rely on the caller to decide whether the cluster is using kube-proxy?
Collaborator
There was a problem hiding this comment.
looks like the logic does not bind to kube proxy, anything that backs a cluster ip can be validated by this, right?
Collaborator
Author
There was a problem hiding this comment.
Good catch. The check isn't kube-proxy specific — it validates ClusterIP service routing, which works regardless of the proxy implementation (kube-proxy, Cilium eBPF, etc.). Renamed it to ValidateClusterIPService and updated the comment
xinWeiWei24
changed the title
Lei Yao (wonderyl)
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds ValidateClusterIPService: deploys a backend behind a ClusterIP and verifies it's reachable from a disposable client pod. Works with any service proxy (kube-proxy, Cilium eBPF); auto-cleans up all resources.