Revert timed-test-suite test integration (keep process_watchdog/timed_test_suite modules)#611
Open
parth21999 wants to merge 1 commit into
Open
Revert timed-test-suite test integration (keep process_watchdog/timed_test_suite modules)#611parth21999 wants to merge 1 commit into
parth21999 wants to merge 1 commit into
Conversation
…_test_suite modules) Reverts #546 (2b14d2e, Convert all tests to TIMED_TEST_SUITE_INITIALIZE/CLEANUP) and #583 (198a0ad, Add real_ps_util_renames to real_process_watchdog). The pipeline-level PowerShell hang watchdog in c-build-tools (produces dumps on timeout) replaces the need for the in-process TIMED_TEST_SUITE integration. This removes the test integration but keeps the process_watchdog and timed_test_suite modules (and their own tests) intact for future use. - Reverts ~88 test-file conversions and PCH timed_test_suite.h includes - Deletes real_process_watchdog reals (only existed to support the integration) - timed_test_suite.h returns to its clean module state (no UMOCK_C_H rename glue) - Conflict files (interlocked_hl_ut, socket_transport_*_ut) auto-resolved keeping later #561/#587 changes while dropping the TIMED integration Co-authored-by: Copilot <[email protected]>
Member
Author
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the in-process
TIMED_TEST_SUITE_INITIALIZE/CLEANUPtest integration. The pipeline-level PowerShell hang watchdog now in c-build-tools (produces full-memory dumps on per-test timeout) replaces the need for the in-process integration, with zero test code changes.This keeps the
process_watchdogandtimed_test_suitemodules (and their own tests) intact for future use — only the integration into the rest of the tests is removed.What this reverts
2b14d2e, Convert all tests to useTIMED_TEST_SUITE_INITIALIZE/CLEANUP)198a0ad, Addreal_ps_util_renamestoreal_process_watchdog)Effect
c_pal/timed_test_suite.hPCH includesreal_process_watchdogreals (these existed only to support the integration)timed_test_suite.hreturns to its clean module state (drops theUMOCK_C_Hrename glue)real_process_watchdog/ extrac_palKept intact
interfaces/inc/c_pal/process_watchdog.h,win32/src/process_watchdog_win32.c,linux/src/process_watchdog_linux.ccommon/inc/c_pal/timed_test_suite.hprocess_watchdog_win32_ut,process_watchdog_linux_ut,process_watchdog_int,timed_test_suite_utVerification
c_pal_repo_validation— PASSEDprocess_watchdog_win32_utandtimed_test_suite_utpass locallyTIMED_TEST_SUITE_*usage orc_pal/timed_test_suite.hincludes outside the module's own testNotes
interlocked_hl_ut,socket_transport_*_ut) were auto-resolved keeping the later changes while dropping the TIMED integration.