Skip to content

Remove default password examples from VM reimage help - #30042

Merged
ZelinWang (wangzelin007) merged 1 commit into
mainfrom
haagha/fix-vmreimage-default-password-doc
Aug 20, 2026
Merged

Remove default password examples from VM reimage help#30042
ZelinWang (wangzelin007) merged 1 commit into
mainfrom
haagha/fix-vmreimage-default-password-doc

Conversation

@haagha

@haagha Haider Agha (haagha) commented Aug 19, 2026

Copy link
Copy Markdown
Member

🤖 PR Validation — ⚠️ Review suggested

Tests
⚠️ 34/34
️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Az.Compute
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Help Example Check
⚠️PowerShell Core - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
⚠️ Invoke-AzVMReimage 2 2 Unassigned_Variable Invoke-AzVMReimage -CustomData $CustomData is a null-valued parameter value. -CustomData Assign value for $CustomData.
⚠️ Invoke-AzVMReimage 2 2 Mismatched_Parameter_Value_Type Invoke-AzVMReimage -AdminPassword $SecurePassword is not an expected parameter value type. -AdminPassword Use correct parameter value type. Expected Type is string. Now the type is securestring.(Command).
⚠️Windows PowerShell - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
⚠️ Invoke-AzVMReimage 2 2 Unassigned_Variable Invoke-AzVMReimage -CustomData $CustomData is a null-valued parameter value. -CustomData Assign value for $CustomData.
⚠️ Invoke-AzVMReimage 2 2 Mismatched_Parameter_Value_Type Invoke-AzVMReimage -AdminPassword $SecurePassword is not an expected parameter value type. -AdminPassword Use correct parameter value type. Expected Type is string. Now the type is securestring.(Command).
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Az.DeviceProvisioningServices
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Test
⚠️PowerShell Core - Linux
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 44.44 % Test coverage for the module cannot be lower than 50%.
⚠️PowerShell Core - MacOS
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 44.44% Test coverage for the module cannot be lower than 50%.
⚠️PowerShell Core - Windows
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 44.44% Test coverage for the module cannot be lower than 50%.
⚠️Windows PowerShell - Windows
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 44.44% Test coverage for the module cannot be lower than 50%.
️✔️Az.EventHub
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Az.IotHub
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Signature Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️File Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Test
⚠️PowerShell Core - Linux
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 0.00 % Test coverage for the module cannot be lower than 50%.
⚠️PowerShell Core - MacOS
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 0.00% Test coverage for the module cannot be lower than 50%.
⚠️PowerShell Core - Windows
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 0.00% Test coverage for the module cannot be lower than 50%.
⚠️Windows PowerShell - Windows
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 0.00% Test coverage for the module cannot be lower than 50%.
️✔️Az.Storage
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows

Summary

  • replace the explicit default-password denylist in Invoke-AzVMReimage help with equivalent guidance
  • avoid false-positive secret detection when the generated help is published to SharePoint

Validation

  • confirmed the branch starts from the current main
  • confirmed the known default-password literals are absent
  • git diff --check passes

@azure-pipelines

Copy link
Copy Markdown
Contributor
Azure Pipelines:
Successfully started running 1 pipeline(s).
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Invoke-AzVMReimage reference help to remove explicit example “default password” literals, reducing false-positive secret scanning when the generated help is published externally (e.g., SharePoint).

Changes:

  • Replaced the explicit password example denylist in -AdminPassword help with equivalent general guidance.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

<br> Has a digit
<br> Has a special character (Regex match [\\W_])
<br><br> **Disallowed values:** \"abc@123\", \"P@$$w0rd\", \"P@ssw0rd\", \"P@ssword123\", \"Pa$$word\", \"pass@word1\", \"Password!\", \"Password1\", \"Password22\", \"iloveyou!\"
<br><br> **Disallowed values:** Common or easily guessed passwords aren't allowed.
@wangzelin007

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Contributor
Azure Pipelines:
Successfully started running 3 pipeline(s).

@wangzelin007
ZelinWang (wangzelin007) merged commit 791ac80 into main Aug 20, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants