Draft
Handle symlink entries correctly in ACR remote build context packing#9071
Conversation
Co-authored-by: bterlson <[email protected]>
Co-authored-by: bterlson <[email protected]>
Copilot
AI
changed the title
[WIP] Fix PackRemoteBuildSource to handle symlinks correctly
Handle symlink entries correctly in ACR remote build context packing
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PackRemoteBuildSourcetreated all non-directory entries as regular files, so symlinked directories in the build context causedio.Copyto read a directory fd (EISDIR) and abort archive creation. It also generated incorrect symlink tar metadata by passinginfo.Name()instead of the symlink target totar.FileInfoHeader.Symlink-aware tar header generation
FileMode.os.Readlink(path).tar.FileInfoHeader(info, linkTarget)so tar entries preserve correctLinkname.Payload copy restricted to regular files
info.Mode().IsRegular().Regression coverage for symlink contexts
TypeSymlink) and preserved link target.